This repository has been archived by the owner on Jan 3, 2018. It is now read-only.
Template for IPython Notebook #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 24, 2014 21:33
Template for ipynb to make lessons have the same style of others markdown lessons and necessary changes in Makefile since now ipynb -> md -> html. This come from @gvwilson. Related to issues: - [site/119](swcarpentry/DEPRECATED-site#119) - [site/321](swcarpentry/DEPRECATED-site#321) - [bc/179](swcarpentry#179)
- Add input mark - Add output mark BUG: - `output.text` in `stream` block end with new line character
|
Looks awesome! |
|
Just discover a small problem with the images, it's write the path to it instead to render it. Working on that. |
- Escape all text input and output. This is require to avoid troubles with `<`, `>` and other characters that have special meaning in HTML - Replace markdown syntax for images output with HTML
|
Does this now include the image path fix? If so, I'll merge it. |
|
@gvwilson Yes. |
|
There's some changes in the Makefile that I don't completely understand (and don't have the time to review right now). Otherwise, this looks good to me. |
|
@r-gaia-cs - These are beautiful! I just checked a local notebook out and the images are rendering fine. I'm +5 for merge ;) ⭐ |
|
@gvwilson - fixes for image paths are in rgaiacs@5659c1b I believe. |
gvwilson
pushed a commit
that referenced
this pull request
Feb 10, 2014
Template for IPython Notebook
rgaiacs
pushed a commit
to rgaiacs/bc
that referenced
this pull request
Feb 13, 2014
Related to issue swcarpentry#289. Fix problem when PR swcarpentry#252 was merged.
|
Update: @gvwilson find the "In[ ]" and "Out[ ]" markers distracting and get rid of it. |
rgaiacs
pushed a commit
to rgaiacs/bc
that referenced
this pull request
Feb 17, 2014
Related to issue swcarpentry#289. Fix problem when PR swcarpentry#252 was merged.
rgaiacs
pushed a commit
to rgaiacs/bc
that referenced
this pull request
Feb 18, 2014
Related to issue swcarpentry#289. Fix problem when PR swcarpentry#252 was merged.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add template to IPython Notebook so when build the lessons it will have the same look of SWC site. In the figure below you see how it look when using the "new" template.
And for comparison, the same lesson in IPython Notebook and with the "old" template.
With this template we lost highlight but we will have the diff tool based on Polyphemus that @scopatz is working on in site/321.